Skip to content

Ensure that all lines of underscores have at least two preceding newlines#8

Merged
technoweenie merged 1 commit intogithub:masterfrom
fatfreecrm:ensure_newline_above_underscores
Dec 11, 2013
Merged

Ensure that all lines of underscores have at least two preceding newlines#8
technoweenie merged 1 commit intogithub:masterfrom
fatfreecrm:ensure_newline_above_underscores

Conversation

@ndbroadbent
Copy link
Copy Markdown
Contributor

Some users may reply directly above a line of underscores, because the gap between lines can be a little misleading, e.g.

Outlook with a reply directly above line
________________________________________
From: CRM Comments [crm-comment@example.com]
Sent: Friday, 23 March 2012 5:08 p.m.
...

Unfortunately, the parser cannot split fragments without empty lines between them.

This pull request solves that problem by ensuring that all underscore lines are preceded by at least two newline characters. (I can't think of any situation where that would cause a problem.)

The previous example will be 'pre-processed' into:

Outlook with a reply directly above line

________________________________________
From: CRM Comments [crm-comment@example.com]
Sent: Friday, 23 March 2012 5:08 p.m.
...

But if this ^ is run through the parser, it will not be affected.

@ndbroadbent
Copy link
Copy Markdown
Contributor Author

Hi there, just wondering if someone might be able to take a look at this pull request?

Cheers!

@Intrepidd
Copy link
Copy Markdown

Great stuff, you saved my life :)

+1 for integration, but sadly this project seems a little bit inactive ..

@inspire22
Copy link
Copy Markdown

Please accept this :)

technoweenie added a commit that referenced this pull request Dec 11, 2013
Ensure that all lines of underscores have at least two preceding newlines
@technoweenie technoweenie merged commit 32021fd into github:master Dec 11, 2013
@Intrepidd
Copy link
Copy Markdown

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants